Apply fix "OpenUSBByName(): the device bus & addr must match" (8b9f6f33) for libusb

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Apply fix "OpenUSBByName(): the device bus & addr must match" (8b9f6f33) for libusb

Stein, Maximilian
Hi,

I noticed that commits [1] and [2], which fixed initialising a wrong USB
device if the PID/VID are identical, only regards pcscd configured with
libudev. In my opinion this can and should be fixed for pcscd configured
with libusb as well. Please see the attached patch.

Kind regards
Maximilian Stein

[1] 8b9f6f33b16e808a5769dbc4193e5f107a09a693 - OpenUSBByName(): the
device bus & addr must match
[2] e46fa30ead3f1eff72769d70be6adf031fafe606 - OpenUSBByName(): use
device bus and address only when available

_______________________________________________
Pcsclite-muscle mailing list
[hidden email]
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pcsclite-muscle

openusbbyname_match_bus_addr_libusb.patch (758 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Apply fix "OpenUSBByName(): the device bus & addr must match" (8b9f6f33) for libusb

Ludovic Rousseau
2017-02-16 16:34 GMT+01:00 Maximilian Stein <[hidden email]>:
Hi,

Hello,
 

I noticed that commits [1] and [2], which fixed initialising a wrong USB
device if the PID/VID are identical, only regards pcscd configured with
libudev. In my opinion this can and should be fixed for pcscd configured
with libusb as well. Please see the attached patch.

Kind regards
Maximilian Stein

[1] 8b9f6f33b16e808a5769dbc4193e5f107a09a693 - OpenUSBByName(): the
device bus & addr must match
[2] e46fa30ead3f1eff72769d70be6adf031fafe606 - OpenUSBByName(): use
device bus and address only when available


You should move your pcsc-lite from libusb-1.0 to libudev for performance reasons.
Unless you have a good reason to still use libusb-1.0 for the hotplug detection?

Thanks

--
 Dr. Ludovic Rousseau

_______________________________________________
Pcsclite-muscle mailing list
[hidden email]
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pcsclite-muscle