Small fix suggestion for CCID (logging issue)

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Small fix suggestion for CCID (logging issue)

Maksim Ivanov
Hello,

There is a small defect in how the CCID driver displays its license text in the log messages:

> Copyright: This driver is protected by terms of the GNU Lesser General
> Public License version 2.1, or (at your opt

The text is cut, because the buffer used for logging (defined at file src/debug.c) is too small.

Adjusting it to something like 3*80 should be enough for displaying the entire license message.


Thanks,
Maksim



_______________________________________________
Pcsclite-muscle mailing list
[hidden email]
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pcsclite-muscle
Reply | Threaded
Open this post in threaded view
|

Re: Small fix suggestion for CCID (logging issue)

Ludovic Rousseau
2016-06-17 21:47 GMT+02:00 Maksim Ivanov <[hidden email]>:
Hello,

There is a small defect in how the CCID driver displays its license text in the log messages:

> Copyright: This driver is protected by terms of the GNU Lesser General
> Public License version 2.1, or (at your opt

The text is cut, because the buffer used for logging (defined at file src/debug.c) is too small.

Adjusting it to something like 3*80 should be enough for displaying the entire license message.


Fixed in 32c8a429a2654e16a195ba42f5a9bbf18f34d87b
https://anonscm.debian.org/cgit/pcsclite/CCID.git/commit/?id=32c8a429a2654e16a195ba42f5a9bbf18f34d87b

The problem is only present on Mac OS X and other systems (Android) where the log is not done by pcscd.
pcscd has a limit of 2048 bytes and does not have this problem.

Thanks

--
 Dr. Ludovic Rousseau

_______________________________________________
Pcsclite-muscle mailing list
[hidden email]
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pcsclite-muscle